tests: add multipath.single-disk to verify that multipath can be reduced to one path
#4359
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new test case, multipath.single-disk, to verify that a multipath device can be correctly reduced to a single path after one of its underlying block devices is removed. The changes include a new test function, modifications to the QEMU platform code to allow for block device removal, and associated test setup. My review focuses on the robustness of the new test logic and code style consistency. I've identified a potential bug in parsing command output within the test and a style inconsistency in one of the new functions.
HuijingHei
force-pushed
the
multipath-one-disk
branch
4 times, most recently
from
fe98f73 to
19f372f
Compare
HuijingHei
changed the title
multipath.single-disk to verify that multipath can bemultipath.single-disk to verify that multipath can be reduced to one path
HuijingHei
force-pushed
the
multipath-one-disk
branch
4 times, most recently
from
1502c7e to
29aadf7
Compare
|
Confirm with @ravanelli , the failed CI |
HuijingHei
force-pushed
the
multipath-one-disk
branch
from
29aadf7 to
e24b255
Compare
|
@ravanelli could you help to review this, as the new coreos-installer is synced to 4.19 plashet now, thank you! |
ravanelli
left a comment
ravanelli
left a comment
There was a problem hiding this comment.
LGTM, just one small comment
HuijingHei
force-pushed
the
multipath-one-disk
branch
from
e24b255 to
9c154ba
Compare
reduced to one path
Reduce disk on multipath via qmp, then reboot.
`{ "execute": "device_del", "arguments": { "id": "/machine/peripheral-anon/device[3]"}}`
See https://issues.redhat.com/browse/OCPBUGS-56597
HuijingHei
force-pushed
the
multipath-one-disk
branch
from
9c154ba to
7ee8b19
Compare
|
Thank you @ravanelli for the review, rebase main branch and see the CI result. |
HuijingHei
force-pushed
the
multipath-one-disk
branch
from
fd97d9f to
089b1bb
Compare
|
@ravanelli would you mind reviewing again, just fix the CI E1101 error. Thank you! |
2 participants
Reduce disk on multipath via qmp, then reboot.
{ "execute": "device_del", "arguments": { "id": "/machine/peripheral-anon/device[3]"}}See https://issues.redhat.com/browse/OCPBUGS-56597